Fixed minifier for Windows users #15893
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes TryGhost#14278 Updated Minifier to use only forward slashes when specifying globs regardless of platform.
|
I just remembered I had a fix for one of the tests in my other prior commits, so I'll take a look at that tomorrow and get that added here. As I recall, one of the tests was a false positive. |
|
Ok, now it should be good. One of the tests wasn't truly checking that it handled a missing file. and tiny-glob doesn't have any option to error when nothing is returned from the pattern so I had to shift around some of the error handling. |
|
Closing as stale for now but please re-open if desired 🙂 |
9larsons
added a commit
that referenced
this pull request
Oct 15, 2024
ref #15893 This got closed as stale long ago. Resurrecting this as it's a simple change and will help our Windows-based theme devs in particular.
9larsons
added a commit
that referenced
this pull request
Nov 21, 2024
ref #15893 This got closed as stale long ago. Resurrecting this as it's a simple change and will help our Windows-based theme devs in particular.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14278.
Updated Minifier to use only forward slashes when specifying globs regardless of platform.
PR #15807 has some additional history. After more testing - and despite globalyzer (dependency of tiny-glob) failing on Windows - tiny-glob does seem to work on Windows as it indicates when you specify a glob using forward slashes. I suppose I ended up going too deep with the initial troubleshooting and missed the more obvious piece here.
This should alleviate your concerns about performance hits from changing packages, although I still feel there would be no impact moving to node-glob as we're fully aware of the directory of the files we want here so no crawling is necessary.